Page MenuHomePhabricator

add Schnorr signing implementation to test_framework
AbandonedPublic

Authored by markblundeberg on Feb 3 2019, 20:01.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Maniphest Tasks
T527: Add Schnorr support to OP_CHECKSIG and OP_CHECKDATASIG
Summary

This adds an independent Schnorr implementation to the functional test
framework's key.py. No new dependencies as it still runs on OpenSSL.
This will be needed so that we can produce real transaction signatures for
activation testing (done in a manner like abc-replay-protection.py)

Includes a basic self-test if you execute the file, to make sure it
produces identical sigs as the implementation in libsecp256k1.

Test Plan

run ./key.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
add_qa_schnorrsign
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4901
Build 7865: Bitcoin ABC Teamcity Staging
Build 7864: arc lint + arc unit

Event Timeline

markblundeberg created this revision.Feb 3 2019, 20:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 3 2019, 20:01
Herald added a subscriber: schancel. · View Herald Transcript

(re-reading ... needs a few comment fixups)

Typo in title:
implemenation -> implementation

markblundeberg retitled this revision from add Schnorr signing implemenation to test_framework to add Schnorr signing implemention to test_framework.Feb 3 2019, 21:08
markblundeberg retitled this revision from add Schnorr signing implemention to test_framework to add Schnorr signing implementation to test_framework.Feb 3 2019, 21:16

Typo in title:
implemenation -> implementation

Wow took me two tries to fix that...

Mengerian added a comment.EditedFeb 3 2019, 22:21

Typo in title:
implemenation -> implementation

Wow took me two tries to fix that...

Macro dog:

markblundeberg updated this revision to Diff 7165.Feb 4 2019, 16:12

rebased ; misc nits

Alternative implementation in its own file, here : D2501

markblundeberg updated this revision to Diff 7217.Feb 7 2019, 18:23

rebased for childrens' sake

deadalnix requested changes to this revision.Feb 8 2019, 23:06

I accepted the other one.

This revision now requires changes to proceed.Feb 8 2019, 23:06
markblundeberg abandoned this revision.Feb 8 2019, 23:35

ok, i liked the other one better anyway