Page MenuHomePhabricator
Differential D2491

Fix a Clang -Wshadow warning in rcu.h
ClosedPublic
Actions

Authored by Fabien on Feb 4 2019, 10:08.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING3f86119db7f1: Fix a Clang -Wshadow warning in rcu.h
rABC3f86119db7f1: Fix a Clang -Wshadow warning in rcu.h
Summary

As per title

Test Plan

Using clang as a compiler:

make check

Ensure there is no -Wshadow warning

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rcu_fix_shadow
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4858
Build 7779: Bitcoin ABC Buildbot (legacy)
Build 7778: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 4 2019, 10:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 4 2019, 10:08
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 4 2019, 10:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 4 2019, 10:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4858: Diff 7151.Feb 4 2019, 10:22
deadalnix requested changes to this revision.Feb 4 2019, 11:48
deadalnix added inline comments.
src/rcu.h
192

rhs

This revision now requires changes to proceed.Feb 4 2019, 11:48
Fabien updated this revision to Diff 7158.Feb 4 2019, 12:09

Rename optr => rhs

teamcity added a comment.Feb 4 2019, 12:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix accepted this revision.Feb 4 2019, 12:20
This revision is now accepted and ready to land.Feb 4 2019, 12:20
teamcity added a comment.Feb 4 2019, 12:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4865: Diff 7158.Feb 4 2019, 12:23
Closed by commit rABC3f86119db7f1: Fix a Clang -Wshadow warning in rcu.h (authored by Fabien). · Explain WhyFeb 4 2019, 15:57
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING3f86119db7f1: Fix a Clang -Wshadow warning in rcu.h.Sep 18 2019, 22:14

Revision Contents
Changeset List

PathSize
src/
4 lines

Diff 7151

View Options

src/rcu.h

Loading...