Page MenuHomePhabricator

Fix a Clang -Wshadow warning in rcu.h
ClosedPublic

Authored by Fabien on Feb 4 2019, 10:08.

Details

Summary

As per title

Test Plan

Using clang as a compiler:

make check

Ensure there is no -Wshadow warning

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rcu_fix_shadow
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 4865
Build 7793: Bitcoin ABC Buildbot (legacy)
Build 7792: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 4 2019, 10:08
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 4 2019, 10:08
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix requested changes to this revision.Feb 4 2019, 11:48
deadalnix added inline comments.
src/rcu.h
192 ↗(On Diff #7151)

rhs

This revision now requires changes to proceed.Feb 4 2019, 11:48
Fabien updated this revision to Diff 7158.Feb 4 2019, 12:09

Rename optr => rhs

deadalnix accepted this revision.Feb 4 2019, 12:20
This revision is now accepted and ready to land.Feb 4 2019, 12:20
This revision was automatically updated to reflect the committed changes.