Page MenuHomePhabricator

script_tests signature function renames to add "ECDSA"
ClosedPublic

Authored by markblundeberg on Feb 8 2019, 00:32.

Details

Summary

Now that Schnorr sigs are there, would be nice to disambiguate both ways. Changes:
DoSign -> DoSignECDSA
PushSig -> PushSigECDSA
PushDataSig -> PushDataSigECDSA

(I left sign_multisig untouched even though it's ECDSA-only; there is no Schnorr counterpart.)

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.Feb 8 2019, 00:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2019, 00:32
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix accepted this revision.Feb 8 2019, 01:58
This revision is now accepted and ready to land.Feb 8 2019, 01:58
Closed by commit rABCf8453ce6fe83: script_tests signature function renames to add "ECDSA" (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyFeb 8 2019, 02:47
This revision was automatically updated to reflect the committed changes.