Merge #10712: Add change output if necessary to reduce excess fee
ClosedPublic
Actions

Authored by jasonbcox on Feb 8 2019, 23:47.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING268be8dd95e0: Merge #10712: Add change output if necessary to reduce excess fee
rABC268be8dd95e0: Merge #10712: Add change output if necessary to reduce excess fee

Summary

0f402b9 Fix rare edge case of paying too many fees when transaction has no change. (Alex Morcos)
253cd7e Only reserve key for scriptChange once in CreateTransaction (Alex Morcos)

Pull request description:

This is an alternative to #10333

See commit messages.

The first commit is mostly code move, it just moves the change creation code out of the loop.

@instagibbs

Tree-SHA512: f16287ae0f0c6f09cf8b1f0db5880bb567ffa74a50898e3d1ef549ba592c6309ae1a9b251739f63a8bb622d48f03ce2dff9e7a57a6bac4afb4b95b0a86613ea8

Backport of Core PR10712
https://github.com/bitcoin/bitcoin/pull/10712/commits
Completes T534

Applied after this fix: D2522
Since this patch was originally reverted due to a test failure: D2517

Test Plan

make check
test_runner.py
test_runner.py rpc_fundrawtransaction

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr10712-again

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4929
Build 7921: Bitcoin ABC Buildbot (legacy)
Build 7920: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 8 2019, 23:47

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 8 2019, 23:47

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B4929: Diff 7256.Feb 9 2019, 00:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix accepted this revision.Feb 9 2019, 20:07

This revision is now accepted and ready to land.Feb 9 2019, 20:07

Closed by commit rABC268be8dd95e0: Merge #10712: Add change output if necessary to reduce excess fee (authored by jasonbcox). · Explain WhyFeb 10 2019, 05:35

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING268be8dd95e0: Merge #10712: Add change output if necessary to reduce excess fee.Sep 18 2019, 22:21

Revision Contents
Changeset List

Path

Size

src/

wallet/

wallet.cpp

137 lines

Diff 7256

View Options

Merge #10712: Add change output if necessary to reduce excess feeClosedPublicActions