Page MenuHomePhabricator
Differential D2542

Format BIP32 test cases manually
ClosedPublic
Actions

Authored by deadalnix on Feb 13 2019, 14:37.

Details

Reviewers
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGING80b07ff83b68: Format BIP32 test cases manually
rABC80b07ff83b68: Format BIP32 test cases manually
Summary

Simple formatting

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
bip32nit
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 4991
Build 8045: Bitcoin ABC Buildbot (legacy)
Build 8044: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 13 2019, 14:37
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 13 2019, 14:37
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 13 2019, 14:38

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 13 2019, 14:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4972: Diff 7319.Feb 13 2019, 14:53
jasonbcox added a subscriber: jasonbcox.Feb 13 2019, 19:30
jasonbcox added inline comments.
src/test/bip32_tests.cpp
91 ↗(On Diff #7319)

Interesting how simple formatting introduces a new testcase :P

What new coverage does this provide? It's not clear how I can verify that it covers anything new.

deadalnix updated this revision to Diff 7348.Feb 14 2019, 16:55

rebase

teamcity added a comment.Feb 14 2019, 16:56

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix updated this revision to Diff 7349.Feb 14 2019, 16:59

Remove test cases added by mistake

teamcity added a comment.Feb 14 2019, 17:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D2553: BIP32 extra test vector.Feb 14 2019, 17:07
teamcity added a comment.Feb 14 2019, 17:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4991: Diff 7348.Feb 14 2019, 17:10
teamcity added a comment.Feb 14 2019, 17:14

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4992: Diff 7349.Feb 14 2019, 17:14
markblundeberg accepted this revision as: markblundeberg.Feb 14 2019, 17:34
markblundeberg added a subscriber: markblundeberg.

Yeah that was hideous before ... linters aren't always right. :-D

This revision is now accepted and ready to land.Feb 14 2019, 17:34
Closed by commit rABC80b07ff83b68: Format BIP32 test cases manually (authored by deadalnix). · Explain WhyFeb 14 2019, 22:43
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rSTAGING80b07ff83b68: Format BIP32 test cases manually.Sep 18 2019, 22:24

Revision Contents
Changeset List

PathSize
src/
test/
109 lines

Diff 7348

View Options

src/test/bip32_tests.cpp

Loading...