Check that key length is correct when deserializing CExtKey
ClosedPublic
Actions

Authored by deadalnix on Feb 14 2019, 14:45.

Details

Reviewers

Group Reviewers

Restricted Project

Commits

rSTAGINGdaec76faa3e7: Check that key length is correct when deserializing CExtKey
rABCdaec76faa3e7: Check that key length is correct when deserializing CExtKey

Summary

Also add test cases for it + test cases for CExtPubKey.

Test Plan

Added test cases.

Diff Detail

Repository

rABC Bitcoin ABC

Branch

serkey

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 4990
Build 8043: Bitcoin ABC Buildbot (legacy)
Build 8042: arc lint + arc unit

Event Timeline

deadalnix created this revision.Feb 14 2019, 14:45

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 14 2019, 14:45

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B4990: Diff 7343.Feb 14 2019, 14:59

jasonbcox accepted this revision.Feb 14 2019, 15:31

This revision is now accepted and ready to land.Feb 14 2019, 15:31

Closed by commit rABCdaec76faa3e7: Check that key length is correct when deserializing CExtKey (authored by deadalnix). · Explain WhyFeb 14 2019, 16:50

This revision was automatically updated to reflect the committed changes.

Backport of https://github.com/bitcoin/bitcoin/pull/11081, with tests

deadalnix added a commit: rSTAGINGdaec76faa3e7: Check that key length is correct when deserializing CExtKey.Sep 18 2019, 22:24

Revision Contents
Changeset List

Path

Size

src/

key.h

4 lines

test/

bip32_tests.cpp

141 lines

Diff 7343

View Options

src/key.h