Page MenuHomePhabricator
Differential D2576

Update test_framework scripts to use the new .format() method
ClosedPublic
Actions

Authored by Fabien on Feb 19 2019, 16:26.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGa78b2f8bae94: Update test_framework scripts to use the new .format() method
rABCa78b2f8bae94: Update test_framework scripts to use the new .format() method
Summary

Avoid using % to format strings, switch to the new method instead.

Test Plan
./test/functional/test_runner.py --extended

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_python_format_test_framework
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5027
Build 8117: Bitcoin ABC Buildbot (legacy)
Build 8116: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 19 2019, 16:26
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 19 2019, 16:26
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 19 2019, 16:27

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 19 2019, 16:41

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5027: Diff 7395.Feb 19 2019, 16:41
deadalnix added inline comments.Feb 19 2019, 19:39
test/functional/test_framework/authproxy.py
54

Is that correct ?

Fabien updated this revision to Diff 7412.Feb 19 2019, 19:59

Fix wrong format in JSONRPCException

teamcity added a comment.Feb 19 2019, 19:59

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Feb 19 2019, 20:13

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5032: Diff 7412.Feb 19 2019, 20:13
Fabien added inline comments.Feb 19 2019, 21:33
test/functional/test_framework/authproxy.py
54

No, good catch. I get confused between named args and dictionary keys, this is now fixed.

deadalnix accepted this revision.Feb 22 2019, 15:09
This revision is now accepted and ready to land.Feb 22 2019, 15:09
Closed by commit rABCa78b2f8bae94: Update test_framework scripts to use the new .format() method (authored by Fabien). · Explain WhyFeb 22 2019, 20:53
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGINGa78b2f8bae94: Update test_framework scripts to use the new .format() method.Sep 18 2019, 22:30

Revision Contents
Changeset List

PathSize
test/
functional/
test_framework/
22 lines
8 lines
23 lines
6 lines
8 lines
109 lines
25 lines
6 lines
24 lines
16 lines
9 lines
4 lines
44 lines

Diff 7395

View Options

test/functional/test_framework/authproxy.py

Loading...
View Options

test/functional/test_framework/cdefs.py

Loading...
View Options

test/functional/test_framework/comptool.py

Loading...
View Options

test/functional/test_framework/coverage.py

Loading...
View Options

test/functional/test_framework/key.py

Loading...
View Options

test/functional/test_framework/messages.py

Loading...
View Options

test/functional/test_framework/mininode.py

Loading...
View Options

test/functional/test_framework/netutil.py

Loading...
View Options

test/functional/test_framework/script.py

Loading...
View Options

test/functional/test_framework/socks5.py

Loading...
View Options

test/functional/test_framework/test_framework.py

Loading...
View Options

test/functional/test_framework/test_node.py

Loading...
View Options

test/functional/test_framework/util.py

Loading...