Replace BTC by BCH in util.py error messages and docstrings
ClosedPublic
Actions

Authored by Fabien on Feb 19 2019, 17:08.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING7fb4bb20827c: Replace BTC by BCH in util.py error messages and docstrings
rABC7fb4bb20827c: Replace BTC by BCH in util.py error messages and docstrings

Summary

As per title

Test Plan

Tweak wallet_basic.py line 31. Replace:

assert_fee_amount(fee, tx_size, fee_per_byte * 1000)

By:

assert_fee_amount(fee, tx_size, fee_per_byte * 10000)

Run:

./test/functional/test_runner.py wallet_basic

Check that there is an assertion (fee too low).
The assertion message should now contains a BCH amount instead of BTC.

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

Fabien created this revision.Feb 19 2019, 17:08

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 19 2019, 17:08

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5029: Diff 7397.Feb 19 2019, 17:23

jasonbcox accepted this revision.Feb 19 2019, 19:22

This revision is now accepted and ready to land.Feb 19 2019, 19:22

Closed by commit rABC7fb4bb20827c: Replace BTC by BCH in util.py error messages and docstrings (authored by Fabien). · Explain WhyFeb 19 2019, 20:00

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGING7fb4bb20827c: Replace BTC by BCH in util.py error messages and docstrings.Sep 18 2019, 22:28

Revision Contents
Changeset List

Path

Size

test/

functional/

test_framework/

util.py

6 lines

Diff 7413

View Options

test/functional/test_framework/util.py

Replace BTC by BCH in util.py error messages and docstringsClosedPublicActions