Page MenuHomePhabricator

Cleanup unused confirm target in GetMinimumFee()
ClosedPublic

Authored by jasonbcox on Feb 22 2019, 01:06.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rABCcb2f3c887ce9: Cleanup unused confirm target in GetMinimumFee()
Summary

See title.
Related to D2543

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Feb 22 2019, 01:06
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 22 2019, 01:06
Herald added a subscriber: schancel. · View Herald Transcript
Fabien accepted this revision.Feb 22 2019, 08:22
Fabien added inline comments.
src/wallet/wallet.cpp
3073 ↗(On Diff #7436)

nTxConfirmTarget is the next one ?
This would remove an unused cli argument: -txconfirmtarget, and the "confirmation target drop down list" which is actually useless.

This revision is now accepted and ready to land.Feb 22 2019, 08:22
jasonbcox added inline comments.Feb 22 2019, 18:42
src/wallet/wallet.cpp
3073 ↗(On Diff #7436)

Ya, nTxConfirmTarget is on my list: T536 When I look into that ticket, I'll be evaluating if it's needed any longer (I expect the answer to be no).

This revision was automatically updated to reflect the committed changes.