Paths

Table of Contentst

Differential D2588

Cleanup unused confirm target in GetMinimumFee()
ClosedPublic
Actions

Authored by jasonbcox on Feb 22 2019, 01:06.

Tags

None

Subscribers

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGcb2f3c887ce9: Cleanup unused confirm target in GetMinimumFee()
rABCcb2f3c887ce9: Cleanup unused confirm target in GetMinimumFee()

Summary

See title.
Related to D2543

Test Plan

make check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

removeconftarget

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5045
Build 8153: Bitcoin ABC Buildbot (legacy)
Build 8152: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 22 2019, 01:06

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 22 2019, 01:06

Herald added a subscriber: schancel. · View Herald Transcript

jasonbcox mentioned this in D2543: Remove unused param from txmempool::estimateFee and estimatefee RPC.Feb 22 2019, 01:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5045: Diff 7436.Feb 22 2019, 01:19

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.Feb 22 2019, 08:22

Fabien added inline comments.

src/wallet/wallet.cpp
3073	`nTxConfirmTarget` is the next one ? This would remove an unused cli argument: `-txconfirmtarget`, and the "confirmation target drop down list" which is actually useless.

This revision is now accepted and ready to land.Feb 22 2019, 08:22

jasonbcox added inline comments.Feb 22 2019, 18:42

src/wallet/wallet.cpp
3073	Ya, nTxConfirmTarget is on my list: T536 When I look into that ticket, I'll be evaluating if it's needed any longer (I expect the answer to be no).

Closed by commit rABCcb2f3c887ce9: Cleanup unused confirm target in GetMinimumFee() (authored by jasonbcox). · Explain WhyFeb 25 2019, 19:01

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGINGcb2f3c887ce9: Cleanup unused confirm target in GetMinimumFee().Sep 18 2019, 22:30

jasonbcox added a reverting change: rSTAGINGf10ed0743aa1: Revert "Cleanup unused confirm target in GetMinimumFee()".

Revision Contents
Changeset List

Path

Size

src/

qt/

coincontroldialog.cpp

4 lines

sendcoinsdialog.cpp

10 lines

wallet/

13 lines

11 lines

13 lines

Diff 7436

src/qt/coincontroldialog.cpp

Loading...

src/qt/sendcoinsdialog.cpp

Loading...

src/wallet/fees.h

Loading...

src/wallet/fees.cpp

Loading...

src/wallet/wallet.cpp

Loading...