Differential D2591

Refactor the imports in abc-* tests
ClosedPublic
Actions

Authored by Fabien on Feb 24 2019, 16:50.

Details

Reviewers

deadalnix

Group Reviewers

Restricted Project

Commits

rSTAGING096c2d9abab0: Refactor the imports in abc-* tests
rABC096c2d9abab0: Refactor the imports in abc-* tests

Summary

Remove all the import *, fix imports from messages and make the layout
consistent across tests.
This will later allow for more checks using flake8.
There is no functional change.

Test Plan

./test/functional/test_runner.py abc-*

Diff Detail

Repository

rABC Bitcoin ABC

Branch

refactor_imports_abc

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5053
Build 8169: Bitcoin ABC Buildbot (legacy)
Build 8168: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 24 2019, 16:50

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 24 2019, 16:50

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5053: Diff 7449.Feb 24 2019, 17:04

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

deadalnix added inline comments.Feb 25 2019, 19:08

test/functional/abc-mempool-accept-txn.py
41	This is really bad. Highly verbose and will create a ton of error for no benefit. What's the upside here ? Having to list every opcode than one uses do not seems to add a lot of value to me.

Fabien added inline comments.Feb 25 2019, 19:24

test/functional/abc-mempool-accept-txn.py
41	This will allow for detection of undefined symbols with flake8. These detections are made impossible when importing all with a star. In the end this changes plus some other to follow are an equivalent to core PR13054.