Fix the mininode/messages imports in example.py
ClosedPublic
Actions

Authored by Fabien on Feb 24 2019, 16:58.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGb67c25f95bc3: Fix the mininode/messages imports in example.py
rABCb67c25f95bc3: Fix the mininode/messages imports in example.py

Summary

When splitting messages.py from mininode.py, a wildcard import from
messages has been kept in mininode to avoid breaking the tests. This
diffs update exemple.py so it does not depend on this workaround.

Test Plan

./test/functional/test_runner.py example_test

Diff Detail

Repository

rABC Bitcoin ABC

Branch

refactor_imports_example

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5061
Build 8185: Bitcoin ABC Buildbot (legacy)
Build 8184: arc lint + arc unit

Event Timeline

Fabien created this revision.Feb 24 2019, 16:58

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 24 2019, 16:58

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5061: Diff 7457.Feb 24 2019, 17:29

jasonbcox accepted this revision.Feb 25 2019, 22:04

This revision is now accepted and ready to land.Feb 25 2019, 22:04

Closed by commit rABCb67c25f95bc3: Fix the mininode/messages imports in example.py (authored by Fabien). · Explain WhyFeb 26 2019, 09:01

This revision was automatically updated to reflect the committed changes.

Fabien added a commit: rSTAGINGb67c25f95bc3: Fix the mininode/messages imports in example.py.Sep 18 2019, 22:32

Revision Contents
Changeset List

Path

Size

test/

functional/

example_test.py

4 lines

Diff 7457

View Options

test/functional/example_test.py

Fix the mininode/messages imports in example.pyClosedPublicActions