Remove redundant check (!ecc is always true)
ClosedPublic
Actions

Authored by jasonbcox on Feb 27 2019, 21:33.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING32f04379b4e5: Remove redundant check (!ecc is always true)
rABC32f04379b4e5: Remove redundant check (!ecc is always true)

Summary

Partial backport of Core PR10898 (commit 7466991)
https://github.com/bitcoin/bitcoin/pull/10898/commits/74669916709e5429990df120c6ba84ac60791b30

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

pr10898-1

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5097
Build 8257: Bitcoin ABC Buildbot (legacy)
Build 8256: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 27 2019, 21:33

Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 27 2019, 21:33

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5097: Diff 7511.Feb 27 2019, 21:46

Fabien accepted this revision.Feb 28 2019, 07:19

This revision is now accepted and ready to land.Feb 28 2019, 07:19

Closed by commit rABC32f04379b4e5: Remove redundant check (!ecc is always true) (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by jasonbcox). · Explain WhyMar 1 2019, 00:36

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING32f04379b4e5: Remove redundant check (!ecc is always true).Sep 18 2019, 22:35

Revision Contents
Changeset List

Path

Size

src/

bitcoin-tx.cpp

13 lines

Diff 7511

View Options

Remove redundant check (!ecc is always true)ClosedPublicActions