Page MenuHomePhabricator
Differential D2625

Avoid NULL pointer dereference when _walletModel is NULL (which is valid)
ClosedPublic
Actions

Authored by jasonbcox on Feb 27 2019, 21:55.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING7839640916c5: Avoid NULL pointer dereference when _walletModel is NULL (which is valid)
rABC7839640916c5: Avoid NULL pointer dereference when _walletModel is NULL (which is valid)
Summary

Partial backport of Core PR10898 (commit 76fed83)
https://github.com/bitcoin/bitcoin/pull/10898/commits/76fed838f381a6efba175f3650ec7e9dc73016d3

Test Plan

ninja check
bitcoin-qt

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10898-5
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5101
Build 8265: Bitcoin ABC Buildbot (legacy)
Build 8264: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Feb 27 2019, 21:55
Herald added a reviewer: Restricted Project. · View Herald TranscriptFeb 27 2019, 21:55
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Feb 27 2019, 21:55

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the test plan for this revision. (Show Details)Feb 27 2019, 21:59
jasonbcox edited the test plan for this revision. (Show Details)
teamcity added a comment.Feb 27 2019, 22:07

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5101: Diff 7515.Feb 27 2019, 22:07
Fabien accepted this revision.Feb 28 2019, 07:28
This revision is now accepted and ready to land.Feb 28 2019, 07:28
Closed by commit rABC7839640916c5: Avoid NULL pointer dereference when _walletModel is NULL (which is valid) (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by jasonbcox). · Explain WhyMar 1 2019, 00:42
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING7839640916c5: Avoid NULL pointer dereference when _walletModel is NULL (which is valid).Sep 18 2019, 22:36

Revision Contents
Changeset List

PathSize
src/
qt/
6 lines

Diff 7515

View Options

src/qt/walletview.cpp

Loading...