Page MenuHomePhabricator

Fix debug build test failures
ClosedPublic

Authored by Fabien on Mar 1 2019, 07:32.

Details

Summary

Running the tests with debug enabled would fail due to the
AssertLockNotHeld(cs_main) introduced in D2608. Some tests are still
locking cs_main when creating a new block, which now throws an
assertion error.
This diff fixes these tests.

Test Plan
../configure --enable-debug && make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_debug_build
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5114
Build 8291: Bitcoin ABC Buildbot (legacy)
Build 8290: arc lint + arc unit

Event Timeline

This revision is now accepted and ready to land.Mar 1 2019, 11:16
src/test/finalization_tests.cpp
33

No braces

53

No braces

67

No braces

90

You don't need braces here.

This revision was automatically updated to reflect the committed changes.