Page MenuHomePhabricator
Differential D2634

Fix debug build test failures
ClosedPublic
Actions

Authored by Fabien on Mar 1 2019, 07:32.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING8c68e96fd677: Fix debug build test failures
rABC8c68e96fd677: Fix debug build test failures
Summary

Running the tests with debug enabled would fail due to the
AssertLockNotHeld(cs_main) introduced in D2608. Some tests are still
locking cs_main when creating a new block, which now throws an
assertion error.
This diff fixes these tests.

Test Plan
../configure --enable-debug && make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_debug_build
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5115
Build 8293: Bitcoin ABC Buildbot (legacy)
Build 8292: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 1 2019, 07:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 1 2019, 07:32
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Mar 1 2019, 07:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 1 2019, 07:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5114: Diff 7549.Mar 1 2019, 07:46
deadalnix accepted this revision.Mar 1 2019, 11:16
This revision is now accepted and ready to land.Mar 1 2019, 11:16
deadalnix added inline comments.Mar 1 2019, 11:17
src/test/finalization_tests.cpp
33 ↗(On Diff #7549)

No braces

53 ↗(On Diff #7549)

No braces

67 ↗(On Diff #7549)

No braces

90 ↗(On Diff #7549)

You don't need braces here.

Fabien updated this revision to Diff 7550.Mar 1 2019, 11:38

Remove useless braces

teamcity added a comment.Mar 1 2019, 11:39

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 1 2019, 11:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5115: Diff 7550.Mar 1 2019, 11:51
Closed by commit rABC8c68e96fd677: Fix debug build test failures (authored by Fabien). · Explain WhyMar 1 2019, 11:53
This revision was automatically updated to reflect the committed changes.
Fabien added a commit: rSTAGING8c68e96fd677: Fix debug build test failures.Sep 18 2019, 22:36

Revision Contents
Changeset List

Diff 7550

View Options

src/test/finalization_tests.cpp

Loading...
View Options

src/test/txvalidationcache_tests.cpp

Loading...