Page MenuHomePhabricator

Partial backport of Core PR9681 to add CWallet::SignTransaction
ClosedPublic

Authored by jasonbcox on Mar 8 2019, 18:56.

Details

Summary

Partial backport (only wallet.* changes in PR9681)
https://github.com/bitcoin/bitcoin/pull/9681/files
Completes T547
Although the function is currently unused, it appears to be used in future backports.
We can remove it later if it proves not useful.

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.Mar 8 2019, 18:56
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 8 2019, 18:56
Herald added a subscriber: schancel. · View Herald Transcript
deadalnix accepted this revision.Mar 8 2019, 21:24
deadalnix added inline comments.
src/wallet/wallet.cpp
2742 ↗(On Diff #7663)

There is no point manipulation Amount by reference.

This revision is now accepted and ready to land.Mar 8 2019, 21:24
jasonbcox added inline comments.Mar 8 2019, 22:33
src/wallet/wallet.cpp
2742 ↗(On Diff #7663)

Ya this is silly. I'll fix it before landing.

jasonbcox updated this revision to Diff 7665.Mar 8 2019, 22:44

Removed reference on Amount

This revision was automatically updated to reflect the committed changes.