Page MenuHomePhabricator
Differential D2697

test: Replace remaining sprintf with snprintf
ClosedPublic
Actions

Authored by Fabien on Mar 18 2019, 12:59.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGb98b41c54ab4: test: Replace remaining sprintf with snprintf
rABCb98b41c54ab4: test: Replace remaining sprintf with snprintf
Summary

Use of sprintf is seen as a red flag as many of its uses are insecure.
OpenBSD warns about it while compiling, and some modern platforms, e.g.
cloudlibc from cloudabi don't
even provide it anymore.

Backport of core PR9867

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR9867
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5231
Build 8525: Bitcoin ABC Buildbot (legacy)
Build 8524: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 18 2019, 12:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2019, 12:59
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a subscriber: teamcity.Mar 18 2019, 13:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 18 2019, 13:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5231: Diff 7723.Mar 18 2019, 13:15
Fabien added a child revision: D2698: [LINTER] build: Add linter for checking accidental locale dependence.Mar 18 2019, 15:27
jasonbcox accepted this revision.Mar 18 2019, 16:52
This revision is now accepted and ready to land.Mar 18 2019, 16:52
deadalnix accepted this revision.Mar 18 2019, 17:09
Closed by commit rABCb98b41c54ab4: test: Replace remaining sprintf with snprintf (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Fabien). · Explain WhyMar 19 2019, 09:32
This revision was automatically updated to reflect the committed changes.
Fabien removed a child revision: D2698: [LINTER] build: Add linter for checking accidental locale dependence.Mar 19 2019, 10:43
Fabien added a commit: rSTAGINGb98b41c54ab4: test: Replace remaining sprintf with snprintf.Sep 18 2019, 22:44

Revision Contents
Changeset List

PathSize
src/
test/
6 lines
7 lines

Diff 7723

View Options

src/test/dbwrapper_tests.cpp

Loading...
View Options

src/uint256.cpp

Loading...