Pass SendCoinsRecipient (208 bytes) by const reference
ClosedPublic
Actions

Authored by nakihito on Mar 18 2019, 22:05.

Details

Reviewers

jasonbcox
Fabien
deadalnix

Group Reviewers

Restricted Owners Package	(Owns No Changed Paths)
Restricted Project

Commits

rSTAGINGc0dc1ba156be: Pass SendCoinsRecipient (208 bytes) by const reference
rABCc0dc1ba156be: Pass SendCoinsRecipient (208 bytes) by const reference

Summary

Completes T559

Backport of PR10964
https://github.com/bitcoin/bitcoin/pull/10964

Test Plan

make check
test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

nakihito created this revision.Mar 18 2019, 22:05

Owners added a reviewer: Restricted Owners Package.Mar 18 2019, 22:05

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 18 2019, 22:05

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox accepted this revision.Mar 18 2019, 22:16

This revision is now accepted and ready to land.Mar 18 2019, 22:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5235: Diff 7728.Mar 18 2019, 22:20

Closed by commit rABCc0dc1ba156be: Pass SendCoinsRecipient (208 bytes) by const reference (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by nakihito). · Explain WhyMar 18 2019, 22:20

This revision was automatically updated to reflect the committed changes.

Nico Guiton <nico@bitframe.org> added a commit: rSTAGINGc0dc1ba156be: Pass SendCoinsRecipient (208 bytes) by const reference.Sep 18 2019, 22:44

Revision Contents
Changeset List

Path

Size

src/

qt/

paymentserver.h

2 lines

paymentserver.cpp

2 lines

test/

paymentservertests.h

2 lines

paymentservertests.cpp

2 lines

Diff 7729

View Options

src/qt/paymentserver.h

View Options

src/qt/paymentserver.cpp

View Options

src/qt/test/paymentservertests.h

View Options

src/qt/test/paymentservertests.cpp

Pass SendCoinsRecipient (208 bytes) by const referenceClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7729

src/qt/paymentserver.h

src/qt/paymentserver.cpp

src/qt/test/paymentservertests.h

src/qt/test/paymentservertests.cpp

Pass SendCoinsRecipient (208 bytes) by const reference
ClosedPublic
Actions

Revision Contents
Changeset List