Backport BlockSource enum class
ClosedPublic
Actions

Authored by jasonbcox on Mar 20 2019, 20:49.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGINGae4d2b98623e: Backport BlockSource enum class
rABCae4d2b98623e: Backport BlockSource enum class

Summary

Partial backport of Core PR 10742 (BlockSource only)
https://github.com/bitcoin/bitcoin/pull/10742/files
Progress towards T549

Test Plan

ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.Mar 20 2019, 20:49

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 20 2019, 20:49

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5254: Diff 7759.Mar 20 2019, 21:04

jasonbcox mentioned this in D2699: Merge #10742: scripted-diff: Use scoped enumerations (C++11, "enum class").Mar 20 2019, 22:45

This needs some braces

This revision is now accepted and ready to land.Mar 21 2019, 09:05

Fabien added a child revision: D2721: Fix braces in qt/clientmodel.cpp.Mar 21 2019, 12:43

Closed by commit rABCae4d2b98623e: Backport BlockSource enum class (authored by jasonbcox). · Explain WhyMar 21 2019, 16:29

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGINGae4d2b98623e: Backport BlockSource enum class.Sep 18 2019, 22:46

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoingui.cpp

8 lines

clientmodel.h

7 lines

clientmodel.cpp

8 lines

Diff 7772

View Options

src/qt/bitcoingui.cpp

View Options

src/qt/clientmodel.h

View Options

Backport BlockSource enum classClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 7772

src/qt/bitcoingui.cpp

src/qt/clientmodel.h

src/qt/clientmodel.cpp

Backport BlockSource enum class
ClosedPublic
Actions

Revision Contents
Changeset List