Page MenuHomePhabricator
Differential D2719

Backport remaining changes from Core PR 10742
ClosedPublic
Actions

Authored by jasonbcox on Mar 20 2019, 22:42.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING5ff091f6080f: Backport remaining changes from Core PR 10742
rABC5ff091f6080f: Backport remaining changes from Core PR 10742
Summary

Partial backport of Core PR 10742
https://github.com/bitcoin/bitcoin/pull/10742/files
Completes T549

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10742-rest
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5260
Build 8583: Bitcoin ABC Buildbot (legacy)
Build 8582: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Mar 20 2019, 22:42
teamcity added a subscriber: teamcity.Mar 20 2019, 22:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox mentioned this in D2699: Merge #10742: scripted-diff: Use scoped enumerations (C++11, "enum class").Mar 20 2019, 22:45
teamcity added a comment.Mar 20 2019, 22:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5260: Diff 7765.Mar 20 2019, 22:58
Fabien requested changes to this revision.Mar 21 2019, 10:10
Fabien added inline comments.
src/wallet/walletdb.cpp
696

This is not part of the original PR because it is removed in PR11923.
https://github.com/bitcoin/bitcoin/pull/11923/files

This revision now requires changes to proceed.Mar 21 2019, 10:10
jasonbcox planned changes to this revision.Mar 26 2019, 23:12

Depends on T570

jasonbcox updated this revision to Diff 7916.Apr 2 2019, 18:47

Rebase

teamcity added a comment.Apr 2 2019, 18:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 2 2019, 19:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5363: Diff 7916.Apr 2 2019, 19:01
Fabien accepted this revision.Apr 2 2019, 19:26
This revision is now accepted and ready to land.Apr 2 2019, 19:26
Closed by commit rABC5ff091f6080f: Backport remaining changes from Core PR 10742 (authored by jasonbcox). · Explain WhyApr 2 2019, 20:28
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING5ff091f6080f: Backport remaining changes from Core PR 10742.Sep 18 2019, 22:51

Revision Contents
Changeset List

PathSize
src/
test/
data/
4 lines
wallet/
2 lines
test/
2 lines
2 lines
40 lines
14 lines
46 lines

Diff 7765

View Options

src/test/data/tx_invalid.json

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/test/accounting_tests.cpp

Loading...
View Options

src/wallet/test/walletdb_tests.cpp

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...