Page MenuHomePhabricator
Differential D2745

[secp256k1] add schnorr verify jni binding
ClosedPublic
Actions

Authored by floreslorca on Mar 27 2019, 22:00.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING6a1c4b55f411: [secp256k1] add schnorr verify jni binding
rABC6a1c4b55f411: [secp256k1] add schnorr verify jni binding
Summary

schnorr jni binding that will allow jvm support

Test Plan

use the test vector data from
https://github.com/sipa/bips/blob/bip-schnorr/bip-schnorr/test-vectors.csv

Diff Detail

Repository
rABC Bitcoin ABC
Branch
sverify1
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5325
Build 8712: Bitcoin ABC Buildbot (legacy)
Build 8711: arc lint + arc unit

Event Timeline

floreslorca created this revision.Mar 27 2019, 22:00
Owners added a reviewer: Restricted Owners Package.Mar 27 2019, 22:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 27 2019, 22:00
Herald added a reviewer: deadalnix. · View Herald Transcript
Herald added a subscriber: schancel. · View Herald Transcript
teamcity added a comment.Mar 27 2019, 22:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

floreslorca edited the test plan for this revision. (Show Details)Mar 27 2019, 22:06
teamcity added a comment.Mar 27 2019, 22:16

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5316: Diff 7847.Mar 27 2019, 22:16
jasonbcox requested changes to this revision.Mar 27 2019, 23:25
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/secp256k1/src/java/org/bitcoin/NativeSecp256k1Test.java
185 ↗(On Diff #7847)

It would be less error prone and easier to read if these tests were formatted with an array of input strings and array of expected outputs. Then just loop over the arrays with a single assertEquals() call on each set.

src/secp256k1/src/java/org/bitcoin/Secp256k1Context.java
34 ↗(On Diff #7847)

Is this related to this diff?

This revision now requires changes to proceed.Mar 27 2019, 23:25
floreslorca updated this revision to Diff 7861.Mar 28 2019, 18:35

add requests and fix revisions

teamcity added a comment.Mar 28 2019, 18:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Mar 28 2019, 18:51

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5325: Diff 7861.Mar 28 2019, 18:51
jasonbcox accepted this revision.Mar 29 2019, 17:10
This revision is now accepted and ready to land.Mar 29 2019, 17:10
Closed by commit rABC6a1c4b55f411: [secp256k1] add schnorr verify jni binding (authored by floreslorca). · Explain WhyMar 29 2019, 17:19
This revision was automatically updated to reflect the committed changes.
floreslorca added a commit: rSTAGING6a1c4b55f411: [secp256k1] add schnorr verify jni binding.Sep 19 2019, 14:53

Revision Contents
Changeset List

PathSize
src/
secp256k1/
src/
java/
org/
bitcoin/
32 lines
153 lines
8 lines
23 lines

Diff 7861

View Options

src/secp256k1/src/java/org/bitcoin/NativeSecp256k1.java

Loading...
View Options

src/secp256k1/src/java/org/bitcoin/NativeSecp256k1Test.java

Loading...
View Options

src/secp256k1/src/java/org_bitcoin_NativeSecp256k1.h

Loading...
View Options

src/secp256k1/src/java/org_bitcoin_NativeSecp256k1.c

Loading...