[LINTER] Enforce a minimum version for autopep8
ClosedPublic
Actions

Authored by Fabien on Mar 29 2019, 10:13.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGINGc018bd540341: [LINTER] Enforce a minimum version for autopep8
rABCc018bd540341: [LINTER] Enforce a minimum version for autopep8

Summary

The behavior of autopep8 differs between older and newer versions.
Enforcing a minimum version is an attempt to enforce the same rules for
everybody, avoiding code conflicts coming to the linter.

The minimum version is selected as being the minimum version shipped
with these OSs:

Ubuntu 18.04 (Ubuntu 16.04 version is older but can be easily

updated)

Debian testing
FreeBSD 12.0
OSX 10.12 Sierra

Test Plan

Should return no error:

arc lint -- test/functional/test_runner.py

Diff Detail

Repository

rABC Bitcoin ABC

Branch

autopep8_version_min

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5333
Build 8728: Bitcoin ABC Buildbot (legacy)
Build 8727: arc lint + arc unit

Event Timeline

Fabien created this revision.Mar 29 2019, 10:13

Herald added a reviewer: Restricted Project. · View Herald TranscriptMar 29 2019, 10:13

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5330: Diff 7867.Mar 29 2019, 10:29

Fabien edited the summary of this revision. (Show Details)Mar 29 2019, 11:19

jasonbcox requested changes to this revision.Mar 29 2019, 16:16

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

arcanist/linter/AutoPEP8Linter.php
40 ↗	(On Diff #7867)	Just a heads up this is not future-proof since some scripts/programs only support `-v` while others support `--version` exclusively or in addition to `-v`. We can jump that hurdle when we get there.
42 ↗	(On Diff #7867)	To make this less fragile for other version number styles, replace `\d+\.\d+\.\d+` with `(\.?\d+)*` so that it can match `x.y` `x.y.z` and `x.y.z.u` without needing special logic.