Fix Windows build errors introduced in D2765
ClosedPublic
Actions

Authored by Fabien on Apr 5 2019, 20:48.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING193d2b9c296a: Fix Windows build errors introduced in D2765
rABC193d2b9c296a: Fix Windows build errors introduced in D2765

Summary

See core issue #12386:
https://github.com/bitcoin/bitcoin/issues/12386

Backport of core PR12416

Test Plan

make check

Build the windows binaries

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR12416

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5398
Build 8858: Bitcoin ABC Buildbot (legacy)
Build 8857: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 5 2019, 20:48

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 5 2019, 20:48

Herald added a reviewer: deadalnix. · View Herald Transcript

Herald added a subscriber: schancel. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien edited the summary of this revision. (Show Details)Apr 5 2019, 20:50

jasonbcox accepted this revision.Apr 5 2019, 20:51

This revision is now accepted and ready to land.Apr 5 2019, 20:51

This revision was landed with ongoing or failed builds.Apr 5 2019, 20:52

Closed by commit rABC193d2b9c296a: Fix Windows build errors introduced in D2765 (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by Fabien). · Explain Why

This revision was automatically updated to reflect the committed changes.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5398: Diff 7971.Apr 5 2019, 21:02

Fabien added a commit: rSTAGING193d2b9c296a: Fix Windows build errors introduced in D2765.Sep 18 2019, 22:53

Revision Contents
Changeset List

Path

Size

src/

qt/

bitcoin.cpp

2 lines

winshutdownmonitor.cpp

5 lines

Diff 7971

View Options

src/qt/bitcoin.cpp