Page MenuHomePhabricator

Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor)
ClosedPublic

Authored by deadalnix on Apr 18 2019, 00:22.

Details

Summary

This is a backport of core PR13532

Test Plan
make check

The function is unit tested

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Apr 18 2019, 00:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 18 2019, 00:22
Fabien added a subscriber: Fabien.Apr 18 2019, 08:32

Can you point me to the test, I can't find it ?

Fabien requested changes to this revision.Apr 18 2019, 08:44

I found it, the unit test is added in D2825.
This is not core ordering, but you may want to rebase D2823 on top of D2825 so this change gets tested.

This revision now requires changes to proceed.Apr 18 2019, 08:44
deadalnix requested review of this revision.Apr 19 2019, 12:25

It's trivial enough, let's not redo everything that has been done for us.

Fabien accepted this revision.Apr 19 2019, 12:30
This revision is now accepted and ready to land.Apr 19 2019, 12:30
This revision was automatically updated to reflect the committed changes.