Page MenuHomePhabricator

Remove the boost/algorithm/string/case_conv.hpp dependency
ClosedPublic

Authored by deadalnix on Apr 18 2019, 00:38.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rABC58e83e2c1128: Remove the boost/algorithm/string/case_conv.hpp dependency
Summary
  • Implements ParseNetwork unit test.

This commit implements a unit test that validates the ParseNetwork(std::string) implementation in netbase.cpp.

  • Implements custom tolower and toupper functions.

This commit implements custom equivalents for the C and C++ tolower and toupper Standard Library functions.
In addition it implements a utility function to capitalize the first letter of a string.

  • Removes the Boost case_conv.hpp dependency.

This commit removes the boost/algorithm/string/case_conv.hpp dependency from the project. It replaces the boost::to_lower and boost::to_upper functions with custom functions that are locale independent and ASCII deterministic.

This is a backport of Core PR13671

Depends on D2824

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

deadalnix created this revision.Apr 18 2019, 00:38
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 18 2019, 00:38
Fabien accepted this revision.Apr 18 2019, 08:49
Fabien added a subscriber: Fabien.
Fabien added inline comments.
src/utilstrencodings.cpp
814 ↗(On Diff #8117)

Braces

This revision is now accepted and ready to land.Apr 18 2019, 08:49
This revision was automatically updated to reflect the committed changes.