Page MenuHomePhabricator

Remove the boost/algorithm/string/case_conv.hpp dependency
ClosedPublic

Authored by deadalnix on Apr 18 2019, 00:38.

Details

Summary
  • Implements ParseNetwork unit test.

This commit implements a unit test that validates the ParseNetwork(std::string) implementation in netbase.cpp.

  • Implements custom tolower and toupper functions.

This commit implements custom equivalents for the C and C++ tolower and toupper Standard Library functions.
In addition it implements a utility function to capitalize the first letter of a string.

  • Removes the Boost case_conv.hpp dependency.

This commit removes the boost/algorithm/string/case_conv.hpp dependency from the project. It replaces the boost::to_lower and boost::to_upper functions with custom functions that are locale independent and ASCII deterministic.

This is a backport of Core PR13671

Depends on D2824

Test Plan
make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
noboostlowercase
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5498
Build 9058: Bitcoin ABC Buildbot (legacy)
Build 9057: arc lint + arc unit