Page MenuHomePhabricator
Differential D2823

Log warning message when deprecated network name 'tor' is used (e.g. option onlynet=tor)
ClosedPublic
Actions

Authored by deadalnix on Apr 18 2019, 00:22.

Details

Reviewers
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING7333ed6b52ff: Log warning message when deprecated network name 'tor' is used (e.g. option…
rABC7333ed6b52ff: Log warning message when deprecated network name 'tor' is used (e.g. option…
Summary

This is a backport of core PR13532

Test Plan
make check

The function is unit tested

Diff Detail

Repository
rABC Bitcoin ABC
Branch
torwarning
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5496
Build 9054: Bitcoin ABC Buildbot (legacy)
Build 9053: arc lint + arc unit

Event Timeline

deadalnix created this revision.Apr 18 2019, 00:22
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 18 2019, 00:22
teamcity added a comment.Apr 18 2019, 00:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

deadalnix added a child revision: D2824: scripted-diff: Replace NET_TOR with NET_ONION.Apr 18 2019, 00:30
Harbormaster completed remote builds in B5496: Diff 8115.Apr 18 2019, 00:36
teamcity added a comment.Apr 18 2019, 00:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien added a subscriber: Fabien.Apr 18 2019, 08:32

Can you point me to the test, I can't find it ?

Fabien requested changes to this revision.Apr 18 2019, 08:44

I found it, the unit test is added in D2825.
This is not core ordering, but you may want to rebase D2823 on top of D2825 so this change gets tested.

This revision now requires changes to proceed.Apr 18 2019, 08:44
deadalnix requested review of this revision.Apr 19 2019, 12:25

It's trivial enough, let's not redo everything that has been done for us.

Fabien accepted this revision.Apr 19 2019, 12:30
This revision is now accepted and ready to land.Apr 19 2019, 12:30
Closed by commit rABC7333ed6b52ff: Log warning message when deprecated network name 'tor' is used (e.g. option… (authored by wodry <wodry@users.noreply.github.com>, committed by deadalnix). · Explain WhyApr 19 2019, 14:24
This revision was automatically updated to reflect the committed changes.
deadalnix added a commit: rSTAGING7333ed6b52ff: Log warning message when deprecated network name 'tor' is used (e.g. option….Sep 18 2019, 23:01

Revision Contents
Changeset List

PathSize
src/
7 lines

Diff 8115

View Options

src/netbase.cpp

Loading...