Page MenuHomePhabricator
Differential D2847

Fix typos.
ClosedPublic
Actions

Authored by nakihito on Apr 20 2019, 01:59.

Details

Reviewers
jasonbcox
deadalnix
Fabien
Group Reviewers
Restricted Owners Package(Owns No Changed Paths)
Restricted Project
Commits
rSTAGING401d5519e296: Fix typos.
rABC401d5519e296: Fix typos.
Summary

Fix typos.

Backport of Core PR 10956
https://github.com/bitcoin/bitcoin/pull/10956/

Depends on D2846

Completes T608

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

nakihito created this revision.Apr 20 2019, 01:59
Owners added a reviewer: Restricted Owners Package.Apr 20 2019, 01:59
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 20 2019, 01:59
teamcity added a comment.Apr 20 2019, 02:00

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 20 2019, 02:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5539: Diff 8180.Apr 20 2019, 02:15
Fabien requested changes to this revision.Apr 20 2019, 12:37
Fabien added inline comments.
src/wallet/wallet.cpp
2791 ↗(On Diff #8180)

You missed the first dont.

This revision now requires changes to proceed.Apr 20 2019, 12:37
nakihito marked an inline comment as done.Apr 21 2019, 18:34
nakihito updated this revision to Diff 8196.Apr 21 2019, 18:35

Fixed missed typo.

teamcity added a comment.Apr 21 2019, 18:36

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.Apr 21 2019, 18:50

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5548: Diff 8196.Apr 21 2019, 18:50
Fabien accepted this revision.Apr 21 2019, 18:52
This revision is now accepted and ready to land.Apr 21 2019, 18:52
nakihito updated this revision to Diff 8334.May 2 2019, 00:56

Rebased.

teamcity added a comment.May 2 2019, 00:58

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5642: Diff 8334.May 2 2019, 01:12
teamcity added a comment.May 2 2019, 01:12

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABC401d5519e296: Fix typos. (authored by practicalswift <practicalswift@users.noreply.github.com>, committed by nakihito). · Explain WhyMay 3 2019, 17:40
This revision was automatically updated to reflect the committed changes.
Nico Guiton <nico@bitframe.org> added a commit: rSTAGING401d5519e296: Fix typos..Sep 18 2019, 23:13

Revision Contents
Changeset List

PathSize
contrib/
linearize/
2 lines
src/
2 lines
qt/
test/
2 lines

Diff 8363

View Options

contrib/linearize/README.md

Loading...
View Options

src/chain.h

Loading...
View Options

src/qt/test/rpcnestedtests.cpp

Loading...