Page MenuHomePhabricator

Use angle bracket in include for src (part 3)
ClosedPublic

Authored by Fabien on Apr 22 2019, 12:46.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCd96e9c6f3e05: Use angle bracket in include for src (part 3)
Summary

As per title

Partial backport of PR11651

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Apr 22 2019, 12:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 22 2019, 12:46
jasonbcox requested changes to this revision.Apr 22 2019, 17:01
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/dstencode.h
9 ↗(On Diff #8201)

separating line between system libs and internal dependencies

src/fs.cpp
1 ↗(On Diff #8201)

Nit: This file needs a copyright notice

src/init.cpp
53 ↗(On Diff #8201)

system libs section should be last

54 ↗(On Diff #8201)

this newline shouldn't exist so that csignal is with the other system libs

This revision now requires changes to proceed.Apr 22 2019, 17:01
Fabien updated this revision to Diff 8211.Apr 22 2019, 17:52

Fix ordering + missing copyright

jasonbcox accepted this revision.Apr 22 2019, 18:47
This revision is now accepted and ready to land.Apr 22 2019, 18:47
This revision was automatically updated to reflect the committed changes.