Use angle bracket in include for src (part 6)
ClosedPublic
Actions

Authored by Fabien on Apr 22 2019, 13:07.

Details

Reviewers

deadalnix
jasonbcox

Group Reviewers

Restricted Project

Commits

rSTAGING197f49b2017b: Use angle bracket in include for src (part 6)
rABC197f49b2017b: Use angle bracket in include for src (part 6)

Summary

As per title

Partial backport of PR11651

Test Plan

make check
ninja check

Diff Detail

Repository

rABC Bitcoin ABC

Branch

PR11651_part29

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5564
Build 9190: Bitcoin ABC Buildbot (legacy)
Build 9189: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 22 2019, 13:07

Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 22 2019, 13:07

Herald added a reviewer: deadalnix. · View Herald Transcript

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5556: Diff 8204.Apr 22 2019, 13:21

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox requested changes to this revision.Apr 22 2019, 17:07

jasonbcox added a subscriber: jasonbcox.

jasonbcox added inline comments.

src/util.h
31 ↗	(On Diff #8204)	system libs after boost
src/utiltime.cpp
12 ↗	(On Diff #8204)	system lib after boost
src/validation.cpp
50 ↗	(On Diff #8204)	ditto
src/validationinterface.cpp
17 ↗	(On Diff #8204)	ditto

This revision now requires changes to proceed.Apr 22 2019, 17:07

Fix ordering

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5564: Diff 8213.Apr 22 2019, 18:24

jasonbcox accepted this revision.Apr 22 2019, 18:48

This revision is now accepted and ready to land.Apr 22 2019, 18:48

Closed by commit rABC197f49b2017b: Use angle bracket in include for src (part 6) (authored by Fabien). · Explain WhyApr 22 2019, 19:24

This revision was automatically updated to reflect the committed changes.

Fabien mentioned this in T649: Backport PR11651.May 10 2019, 09:48

Fabien added a commit: rSTAGING197f49b2017b: Use angle bracket in include for src (part 6).Sep 18 2019, 23:06

Revision Contents
Changeset List

Path

Size

src/

13 lines

38 lines

5 lines

2 lines

4 lines

8 lines

20 lines

30 lines

4 lines

8 lines

4 lines

8 lines

24 lines

86 lines

validationinterface.h

2 lines

validationinterface.cpp

19 lines

walletinitinterface.h

2 lines

warnings.cpp

9 lines

Diff 8213

View Options

src/txmempool.h

View Options

src/txmempool.cpp

View Options

src/ui_interface.cpp

View Options

src/uint256.h

View Options

src/uint256.cpp

View Options

src/undo.h

View Options

src/util.h

View Options

src/util.cpp

View Options

src/utilmoneystr.h

View Options

src/utilmoneystr.cpp

View Options

src/utilstrencodings.cpp

View Options

src/utiltime.cpp

View Options

src/validation.h

View Options

src/validation.cpp

View Options

src/validationinterface.h

View Options

src/validationinterface.cpp

View Options

src/walletinitinterface.h

View Options

Use angle bracket in include for src (part 6)ClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8213

src/txmempool.h

src/txmempool.cpp

src/ui_interface.cpp

src/uint256.h

src/uint256.cpp

src/undo.h

src/util.h

src/util.cpp

src/utilmoneystr.h

src/utilmoneystr.cpp

src/utilstrencodings.cpp

src/utiltime.cpp

src/validation.h

src/validation.cpp

src/validationinterface.h

src/validationinterface.cpp

src/walletinitinterface.h

src/warnings.cpp

Use angle bracket in include for src (part 6)
ClosedPublic
Actions

Revision Contents
Changeset List