Page MenuHomePhabricator

Use angle bracket in include for wallet
ClosedPublic

Authored by Fabien on Apr 23 2019, 07:33.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rABCf05e34fccfe8: Use angle bracket in include for wallet
Summary

As per title

Partial backport of PR11651

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

Fabien created this revision.Apr 23 2019, 07:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2019, 07:33
Fabien updated this revision to Diff 8239.Apr 23 2019, 08:07

Attempt to upload missing files to the diff, no idea what is happening

Fabien updated this revision to Diff 8241.Apr 23 2019, 10:16

Add an include in coincontrol.h that would make wallet tests to fail compiling due to include reordering.

Fabien added inline comments.Apr 23 2019, 10:18
src/wallet/coincontrol.h
9 ↗(On Diff #8241)

This include has been added by core in PR9592.
Reordering the includes in wallet_tests.cpp made it a requirement for the build.

jasonbcox accepted this revision.Apr 24 2019, 22:48
This revision is now accepted and ready to land.Apr 24 2019, 22:48
This revision was automatically updated to reflect the committed changes.