Page MenuHomePhabricator
Differential D2869

Use angle bracket in include for wallet
ClosedPublic
Actions

Authored by Fabien on Apr 23 2019, 07:33.

Details

Reviewers
deadalnix
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGf05e34fccfe8: Use angle bracket in include for wallet
rABCf05e34fccfe8: Use angle bracket in include for wallet
Summary

As per title

Partial backport of PR11651

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11651_part21
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5580
Build 9222: Bitcoin ABC Buildbot (legacy)
Build 9221: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 23 2019, 07:33
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2019, 07:33
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.Apr 23 2019, 07:34

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5578: Diff 8237.Apr 23 2019, 07:47
teamcity added a comment.Apr 23 2019, 07:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien updated this revision to Diff 8239.Apr 23 2019, 08:07

Attempt to upload missing files to the diff, no idea what is happening

teamcity added a comment.Apr 23 2019, 08:08

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien mentioned this in D2870: Use angle bracket in include for wallet test.Apr 23 2019, 08:09
Fabien added a child revision: D2870: Use angle bracket in include for wallet test.Apr 23 2019, 08:09
teamcity added a comment.Apr 23 2019, 08:22

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5580: Diff 8239.Apr 23 2019, 08:22
Fabien updated this revision to Diff 8241.Apr 23 2019, 10:16

Add an include in coincontrol.h that would make wallet tests to fail compiling due to include reordering.

teamcity added a comment.Apr 23 2019, 10:17

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Fabien added inline comments.Apr 23 2019, 10:18
src/wallet/coincontrol.h
9 ↗(On Diff #8241)

This include has been added by core in PR9592.
Reordering the includes in wallet_tests.cpp made it a requirement for the build.

Harbormaster completed remote builds in B5582: Diff 8241.Apr 23 2019, 10:31
teamcity added a comment.Apr 23 2019, 10:31

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.Apr 24 2019, 22:48
This revision is now accepted and ready to land.Apr 24 2019, 22:48
Closed by commit rABCf05e34fccfe8: Use angle bracket in include for wallet (authored by Fabien). · Explain WhyApr 25 2019, 06:24
This revision was automatically updated to reflect the committed changes.
Fabien mentioned this in T649: Backport PR11651.May 10 2019, 09:48
Fabien added a commit: rSTAGINGf05e34fccfe8: Use angle bracket in include for wallet.Sep 18 2019, 23:08

Revision Contents
Changeset List

PathSize
src/
wallet/
2 lines
6 lines
12 lines
16 lines
17 lines
2 lines
18 lines
10 lines
20 lines
32 lines
22 lines
58 lines
10 lines
26 lines

Diff 8239

View Options

src/wallet/coincontrol.h

Loading...
View Options

src/wallet/crypter.h

Loading...
View Options

src/wallet/crypter.cpp

Loading...
View Options

src/wallet/db.h

Loading...
View Options

src/wallet/db.cpp

Loading...
View Options

src/wallet/fees.h

Loading...
View Options

src/wallet/fees.cpp

Loading...
View Options

src/wallet/finaltx.cpp

Loading...
View Options

src/wallet/init.cpp

Loading...
View Options

src/wallet/rpcdump.cpp

Loading...
View Options

src/wallet/wallet.h

Loading...
View Options

src/wallet/wallet.cpp

Loading...
View Options

src/wallet/walletdb.h

Loading...
View Options

src/wallet/walletdb.cpp

Loading...