Page MenuHomePhabricator

Use angle bracket in include for wallet test
ClosedPublic

Authored by Fabien on Apr 23 2019, 07:39.

Details

Summary

As per title

Partial backport of PR11651

Depends on D2869

Test Plan
make check
ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
PR11651_part22
Lint
Lint OK
Unit
No Unit Test Coverage
Build Status
Buildable 5579
Build 9220: Bitcoin ABC Buildbot (legacy)
Build 9219: arc lint + arc unit

Event Timeline

Fabien created this revision.Apr 23 2019, 07:39
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 23 2019, 07:39
Fabien updated this revision to Diff 8240.Apr 23 2019, 08:09

Depends on D2869

Fabien edited the summary of this revision. (Show Details)Apr 23 2019, 08:09
Fabien planned changes to this revision.Apr 23 2019, 08:35
Fabien updated this revision to Diff 8242.Apr 23 2019, 10:20

Rebase

jasonbcox requested changes to this revision.Apr 24 2019, 22:46
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
src/wallet/test/wallet_tests.cpp
12 ↗(On Diff #8242)

Similar to the changes in walletdb_tests.cpp, these three wallet/ includes should be in their own section above this one.

This revision now requires changes to proceed.Apr 24 2019, 22:46
jasonbcox accepted this revision.Apr 25 2019, 15:35

Realized my comment isn't really standardizable across all source files, so ignore me.

This revision is now accepted and ready to land.Apr 25 2019, 15:35
This revision was automatically updated to reflect the committed changes.