Partial backport of Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/a0704a8996bb950ae3c4d5b5a30e9dfe34cde1d3
Progress towards T417
Depends on D2871, D2876
Details
Details
- Reviewers
deadalnix Fabien - Group Reviewers
Restricted Project - Commits
- rSTAGINGb2b842fed456: Remove most direct bitcoin calls from qt/walletmodel.cpp
rABCb2b842fed456: Remove most direct bitcoin calls from qt/walletmodel.cpp
make check
ninja check
bitcoin-qt # sanity checks; perform transactions and make sure affected dialog boxes behave as expected
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- walletmodel
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5593 Build 9248: Bitcoin ABC Buildbot (legacy) Build 9247: arc lint + arc unit
Event Timeline
| src/interfaces/node.h | ||
|---|---|---|
| 151 | getTxConfirmTarget was left out because confirm target is not supported | |
| src/interfaces/wallet.cpp | ||
| 19 |
| |
| src/interfaces/wallet.h | ||
| 149 | Address type and change type do not exist in ABC. | |
| src/qt/sendcoinsdialog.cpp | ||
| 223 | nConfTarget no longer supported | |
| src/qt/transactionview.cpp | ||
| 416 | bumping txs (RBF) isn't supported by ABC | |
| src/qt/walletmodel.cpp | ||
| 256 | Removed parentheses even though the original PR didn't because the locks no longer exist and there's no reason to maintain limited scope here. | |
| 301 | Removed parentheses even though the original PR didn't because the locks no longer exist and there's no reason to maintain limited scope here. | |
| src/qt/walletmodel.h | ||
| 218 | ABC doesn't support bumping fees, bumping txs, or conf target. | |
| src/qt/walletmodeltransaction.cpp | ||
| 23 | Virtual size is for segwit, which ABC doesn't support | |
| src/qt/sendcoinsdialog.cpp | ||
|---|---|---|
| 16 ↗ | (On Diff #8262) | This is removed in https://github.com/bitcoin/bitcoin/pull/10574 |
| src/qt/transactionview.cpp | ||
| 373 ↗ | (On Diff #8262) | Could you rebase upon D2876 ? |
| src/qt/walletmodel.cpp | ||
| 127 ↗ | (On Diff #8262) | This is good, but seems unrelated ? |
| 187 ↗ | (On Diff #8262) | dito |
| 227 ↗ | (On Diff #8262) | Update the comments layout |
| 280 ↗ | (On Diff #8262) | dito |
| 503 ↗ | (On Diff #8262) | dito |
| 527 ↗ | (On Diff #8262) | dito |
| src/qt/transactionview.cpp | ||
|---|---|---|
| 373 ↗ | (On Diff #8262) | Done. |
| src/qt/walletmodel.cpp | ||
| 127 ↗ | (On Diff #8262) | I went ahead and cleaned this up because it was tightly related to the chain I described in the below comment(s). |
| 187 ↗ | (On Diff #8262) | Required. See comment below. |
| 227 ↗ | (On Diff #8262) | I did this to match the original PR for reduced merge conflicts. It fits within our linting rules, so I left it. |
| 280 ↗ | (On Diff #8262) | Required. See comment below. |
| 503 ↗ | (On Diff #8262) | Required. See comment below. |
| 527 ↗ | (On Diff #8262) | This is subtle, but necessary. wallet -> m_wallet changed type in addition to naming. m_wallet doesn't have direct access to chainparams. |
| src/qt/sendcoinsdialog.cpp | ||
|---|---|---|
| 16 ↗ | (On Diff #8262) | This hasn't been backported yet but the looks of it? |
| src/qt/sendcoinsdialog.cpp | ||
|---|---|---|
| 5 ↗ | (On Diff #8262) | Please reorder for consistency. |
| 16 ↗ | (On Diff #8262) | This is a missing dependency. |
| src/qt/walletmodel.cpp | ||
| 7 ↗ | (On Diff #8262) | Dito |
| 227 ↗ | (On Diff #8262) | OK I let this up to you |
| 527 ↗ | (On Diff #8262) | Got it, thanks |
| src/qt/walletmodel.h | ||
| 8 ↗ | (On Diff #8262) | Please reorder. |