Extracted from the recent changes to the header inclusions.
Details
Details
- Reviewers
deadalnix jasonbcox - Group Reviewers
Restricted Project - Commits
- rSTAGING1f126a0b8f42: [DOC] Add headers inclusion guidelines to the developer notes
rABC1f126a0b8f42: [DOC] Add headers inclusion guidelines to the developer notes
Read it.
Diff Detail
Diff Detail
- Repository
- rABC Bitcoin ABC
- Branch
- doc_header_ordering
- Lint
Lint Passed - Unit
No Test Coverage - Build Status
Buildable 5601 Build 9264: Bitcoin ABC Buildbot (legacy) Build 9263: arc lint + arc unit
Event Timeline
| doc/developer-notes.md | ||
|---|---|---|
| 501 ↗ | (On Diff #8272) | My suggested addition at the end: - In order to make the code consistent, header files should be included in the following order, with each section separated by a newline: |
| 502 ↗ | (On Diff #8272) | block -> section (just because block is so heavily used in other contexts :P) |
| 503 ↗ | (On Diff #8272) | for -> from |
| 506 ↗ | (On Diff #8272) | Should we mention anything about internal 3rd party dependencies (ie: univalue) and external (ie: boost)? I've always imagined that internal dependencies should always come before external, though I admit I don't have strong reasoning for this beyond that it seems reasonable to me. |