Page MenuHomePhabricator
Differential D2885

Remove direct bitcoin calls from qt/addresstablemodel.cpp
ClosedPublic
Actions

Authored by jasonbcox on Apr 29 2019, 16:00.

Details

Reviewers
deadalnix
Fabien
Group Reviewers
Restricted Project
Commits
rSTAGING02fb9f37a5bc: Remove direct bitcoin calls from qt/addresstablemodel.cpp
rABC02fb9f37a5bc: Remove direct bitcoin calls from qt/addresstablemodel.cpp
Summary

Partial backport of Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/3ec2ebcd9b4beb4277f1f4791c6acbc538784f70
Progress on T417

Test Plan

make check
bitcoin-qt # sanity checking address table

Diff Detail

Repository
rABC Bitcoin ABC
Branch
addrtable
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5618
Build 9298: Bitcoin ABC Buildbot (legacy)
Build 9297: arc lint + arc unit

Event Timeline

jasonbcox created this revision.Apr 29 2019, 16:00
Herald added a reviewer: Restricted Project. · View Herald TranscriptApr 29 2019, 16:00
teamcity added a comment.Apr 29 2019, 16:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox updated this revision to Diff 8296.Apr 29 2019, 16:09

Removed superfluous brackets

teamcity added a comment.Apr 29 2019, 16:10

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5617: Diff 8295.Apr 29 2019, 16:15
teamcity added a comment.Apr 29 2019, 16:15

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

teamcity added a comment.Apr 29 2019, 16:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5618: Diff 8296.Apr 29 2019, 16:23
jasonbcox added a child revision: D2886: Remove direct bitcoin calls from qt/paymentserver.cpp.Apr 29 2019, 18:46
Fabien accepted this revision.Apr 30 2019, 10:15
Fabien added inline comments.
src/interfaces/wallet.h
12

Nit: restore the spaces before the comments to avoid breaking the alignment

This revision is now accepted and ready to land.Apr 30 2019, 10:15
jasonbcox added inline comments.Apr 30 2019, 16:13
src/interfaces/wallet.h
12

Linter doesn't want it... lol

111 ↗(On Diff #8295)

Removed learnRelatedScripts since it's segwit related.

226 ↗(On Diff #8295)

Renamed these variables since they shadow the member variables.

Closed by commit rABC02fb9f37a5bc: Remove direct bitcoin calls from qt/addresstablemodel.cpp (authored by jasonbcox). · Explain WhyApr 30 2019, 16:13
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGING02fb9f37a5bc: Remove direct bitcoin calls from qt/addresstablemodel.cpp.Sep 18 2019, 23:09

Revision Contents
Changeset List

PathSize
src/
interfaces/
32 lines
15 lines
qt/
7 lines
105 lines
2 lines

Diff 8296

View Options

src/interfaces/wallet.h

Loading...
View Options

src/interfaces/wallet.cpp

Loading...
View Options

src/qt/addresstablemodel.h

Loading...
View Options

src/qt/addresstablemodel.cpp

Loading...
View Options

src/qt/walletmodel.cpp

Loading...