Use WalletBalances struct in Qt
ClosedPublic
Actions

Authored by jasonbcox on May 2 2019, 00:03.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING23a0cd463cfe: Use WalletBalances struct in Qt
rABC23a0cd463cfe: Use WalletBalances struct in Qt

Summary

Suggested by John Newbery <john@johnnewbery.com>
https://github.com/bitcoin/bitcoin/pull/10244#discussion_r177504284

Partial backport of Core PR 10244
https://github.com/bitcoin/bitcoin/pull/10244/commits/9a61eed1fcc16ddcedc315045f470e1958b0760b
Progress towards T417
Depends on D2889

Test Plan

make check
ninja check
bitcoin-qt # sanity checks

Diff Detail

Repository

rABC Bitcoin ABC

Branch

walletbal

Lint

Lint Passed

Unit

No Test Coverage

Build Status

Buildable 5640
Build 9342: Bitcoin ABC Buildbot (legacy)
Build 9341: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 2 2019, 00:03

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 2 2019, 00:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

jasonbcox edited the summary of this revision. (Show Details)May 2 2019, 00:11

jasonbcox added a parent revision: D2889: Remove direct bitcoin calls from qt/sendcoinsdialog.cpp.

Harbormaster completed remote builds in B5640: Diff 8331.May 2 2019, 00:18

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Fabien accepted this revision.May 2 2019, 06:06

This revision is now accepted and ready to land.May 2 2019, 06:06

Closed by commit rABC23a0cd463cfe: Use WalletBalances struct in Qt (authored by Russell Yanofsky <russ@yanofsky.org>, committed by jasonbcox). · Explain WhyMay 2 2019, 20:04

This revision was automatically updated to reflect the committed changes.

jasonbcox added a commit: rSTAGING23a0cd463cfe: Use WalletBalances struct in Qt.Sep 18 2019, 23:12

Revision Contents
Changeset List

Path

Size

src/

qt/

14 lines

108 lines

7 lines

31 lines

6 lines

6 lines

Diff 8331

View Options

src/qt/overviewpage.h

View Options

src/qt/overviewpage.cpp

View Options

src/qt/sendcoinsdialog.h

View Options

src/qt/sendcoinsdialog.cpp

View Options

src/qt/walletmodel.h

View Options

Use WalletBalances struct in QtClosedPublicActions

Details

Diff Detail

Event Timeline

Revision ContentsChangeset List

Diff 8331

src/qt/overviewpage.h

src/qt/overviewpage.cpp

src/qt/sendcoinsdialog.h

src/qt/sendcoinsdialog.cpp

src/qt/walletmodel.h

src/qt/walletmodel.cpp

Use WalletBalances struct in Qt
ClosedPublic
Actions

Revision Contents
Changeset List