Page MenuHomePhabricator
Differential D2923

fix out-of-bounds memory write in key_tests
ClosedPublic
Actions

Authored by markblundeberg on May 4 2019, 16:48.

Details

Reviewers
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGING8836ff3e2d5f: fix out-of-bounds memory write in key_tests
rABC8836ff3e2d5f: fix out-of-bounds memory write in key_tests
Summary

Introduced by me in D2348. Thanks to Jason for catching this with ASan.

Test Plan

make check

I ran ASan-compiled ./src/test/test_bitcoin --run_test=key_tests with and without this patch. Prior to patch it revealed memory error "WRITE of size 32"; afterwards it has no errors.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
fix_key_tests
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5672
Build 9406: Bitcoin ABC Buildbot (legacy)
Build 9405: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 4 2019, 16:48
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 4 2019, 16:48
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 4 2019, 16:49

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5672: Diff 8380.May 4 2019, 17:03
teamcity added a comment.May 4 2019, 17:03

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

markblundeberg edited the test plan for this revision. (Show Details)May 4 2019, 17:24
markblundeberg edited the test plan for this revision. (Show Details)
markblundeberg added a comment.May 4 2019, 17:26

Bug was that even when rlen < 32, it always tries to write 32 bytes into ret, but offset such that it would write past the end of ret.

markblundeberg edited the test plan for this revision. (Show Details)May 4 2019, 18:02
deadalnix accepted this revision.May 4 2019, 18:26
This revision is now accepted and ready to land.May 4 2019, 18:26
Closed by commit rABC8836ff3e2d5f: fix out-of-bounds memory write in key_tests (authored by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 4 2019, 20:03
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGING8836ff3e2d5f: fix out-of-bounds memory write in key_tests.Sep 18 2019, 23:15

Revision Contents
Changeset List

PathSize
src/
test/
2 lines

Diff 8380

View Options

src/test/key_tests.cpp

Loading...