Page MenuHomePhabricator

fix out-of-bounds memory write in key_tests
ClosedPublic

Authored by markblundeberg on May 4 2019, 16:48.

Details

Summary

Introduced by me in D2348. Thanks to Jason for catching this with ASan.

Test Plan

make check

I ran ASan-compiled ./src/test/test_bitcoin --run_test=key_tests with and without this patch. Prior to patch it revealed memory error "WRITE of size 32"; afterwards it has no errors.

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Lint Not Applicable
Unit
Tests Not Applicable

Event Timeline

markblundeberg edited the test plan for this revision. (Show Details)

Bug was that even when rlen < 32, it always tries to write 32 bytes into ret, but offset such that it would write past the end of ret.

This revision is now accepted and ready to land.May 4 2019, 18:26