Page MenuHomePhabricator
Differential D2940

Merge #10029: Fix parameter naming inconsistencies between .h and .cpp files
ClosedPublic
Actions

Authored by jasonbcox on May 6 2019, 19:32.

Details

Reviewers
deadalnix
Fabien
markblundeberg
Group Reviewers
Restricted Project
Commits
rSTAGINGb3bfd0767d45: Merge #10029: Fix parameter naming inconsistencies between .h and .cpp files
rABCb3bfd0767d45: Merge #10029: Fix parameter naming inconsistencies between .h and .cpp files
Summary

97b8213 Fix parameter naming inconsistencies between .h and .cpp files (practicalswift)

Tree-SHA512: 4f46cc3973a898d2478bdb1b8c8d1829c3a7298b63bc47359c5dc2f135466773072d9672134ef3e7557dfc913720e49b675176b9e435b8bd1992af9ad53866e4

Backport of Core PR 10029
https://github.com/bitcoin/bitcoin/pull/10029/files

Test Plan

ninja check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr10029
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5697
Build 9456: Bitcoin ABC Buildbot (legacy)
Build 9455: arc lint + arc unit

Event Timeline

jasonbcox created this revision.May 6 2019, 19:32
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2019, 19:32
teamcity added a comment.May 6 2019, 19:33

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a comment.May 6 2019, 19:37

checked with the respective files & confirm this resolves inconsistency.

markblundeberg accepted this revision.May 6 2019, 19:37
This revision is now accepted and ready to land.May 6 2019, 19:37
jasonbcox added a comment.May 6 2019, 19:44

Note for reviewers: txmempool.* changes are not necessary since we've already renamed them to more appropriate names.

Harbormaster completed remote builds in B5697: Diff 8420.May 6 2019, 19:46
teamcity added a comment.May 6 2019, 19:46

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Closed by commit rABCb3bfd0767d45: Merge #10029: Fix parameter naming inconsistencies between .h and .cpp files (authored by Jonas Schnelli <dev@jonasschnelli.ch>, committed by jasonbcox). · Explain WhyMay 6 2019, 19:49
This revision was automatically updated to reflect the committed changes.
jasonbcox added a commit: rSTAGINGb3bfd0767d45: Merge #10029: Fix parameter naming inconsistencies between .h and .cpp files.Sep 18 2019, 23:16

Revision Contents
Changeset List

PathSize
src/
4 lines
rpc/
2 lines
2 lines

Diff 8420

View Options

src/core_write.cpp

Loading...
View Options

src/rpc/server.h

Loading...
View Options

src/validation.h

Loading...