Page MenuHomePhabricator
Differential D2941

Backport dev notes on RPC
ClosedPublic
Actions

Authored by deadalnix on May 6 2019, 20:52.

Details

Reviewers
jasonbcox
Group Reviewers
Restricted Project
Commits
rSTAGINGe77c51451d36: Backport dev notes on RPC
rABCe77c51451d36: Backport dev notes on RPC
Summary

As per title. All at once.

Test Plan
\o/

Diff Detail

Repository
rABC Bitcoin ABC
Branch
rpcdoc
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5699
Build 9460: Bitcoin ABC Buildbot (legacy)
Build 9459: arc lint + arc unit

Event Timeline

deadalnix created this revision.May 6 2019, 20:52
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2019, 20:52
teamcity added a comment.May 6 2019, 20:53

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 6 2019, 21:06

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5699: Diff 8423.May 6 2019, 21:06
jasonbcox accepted this revision.May 6 2019, 21:29
jasonbcox added a subscriber: jasonbcox.
jasonbcox added inline comments.
doc/developer-notes.md
633

We don't actually follow this guideline, but considering the lack of code consistency on this front, I think we should leave this to be the "official" guildeline until backports are up-to-date.

This revision is now accepted and ready to land.May 6 2019, 21:29
Closed by commit rABCe77c51451d36: Backport dev notes on RPC (authored by Matt Corallo <git@bluematt.me>, committed by deadalnix). · Explain WhyMay 6 2019, 23:06
This revision was automatically updated to reflect the committed changes.
nakihito mentioned this in D3344: Merge #10999: Fix amounts formatting in `decoderawtransaction`.Jun 15 2019, 01:07
markblundeberg mentioned this in T436: Backport core PR 10286.Jul 10 2019, 18:33
deadalnix added a commit: rSTAGINGe77c51451d36: Backport dev notes on RPC.Sep 18 2019, 23:17

Revision Contents
Changeset List

PathSize
doc/
89 lines

Diff 8423

View Options

doc/developer-notes.md

Loading...