Page MenuHomePhabricator

Merge #13080: mempool: Add compile time checking for ::mempool.cs runtime locking assertions
ClosedPublic

Authored by jasonbcox on May 7 2019, 00:16.

Details

Summary

cbba1d2da4 Add compile time checking for all ::mempool.cs runtime locking assertions (practicalswift)

Pull request description:

Add compile time checking for `::mempool.cs` runtime locking assertions.

This PR is a subset of #12665. The PR was broken up to make reviewing easier.

The intention is that literally all `EXCLUSIVE_LOCKS_REQUIRED`/`LOCKS_EXCLUDED`:s added in this PR should follow either directly or indirectly from `AssertLockHeld(…)`/`AssertLockNotHeld(…)`:s already existing in the repo.

Consider the case where function `A(…)` contains `AssertLockHeld(cs_foo)` (without
first locking `cs_foo` in `A`), and that `B(…)` calls `A(…)` (without first locking `cs_main`):
* It _directly_ follows that: `A(…)` should have an `EXCLUSIVE_LOCKS_REQUIRED(cs_foo)` annotation.
* It _indirectly_ follows that: `B(…)` should have an `EXCLUSIVE_LOCKS_REQUIRED(cs_foo)` annotation.

Tree-SHA512: 1b5ec1cfca6be67edd1298fea1a52b5572ce833dd4ad05c4583f753c2d3229402663373675df87e950151d5c41aeb3ee02f0ad935ed83fe2f45ca8e4d55d901e

Backport Core PR 13080
https://github.com/bitcoin/bitcoin/pull/13080/files
Depends on D2952

Test Plan

make check
test_runner.py

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

jasonbcox created this revision.May 7 2019, 00:16
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 7 2019, 00:16
Fabien accepted this revision.May 7 2019, 08:04
This revision is now accepted and ready to land.May 7 2019, 08:04
This revision was automatically updated to reflect the committed changes.