Merge #11099: [RPC][mempool]: Add savemempool RPC
ClosedPublic
Actions

Authored by jasonbcox on May 6 2019, 23:09.

Details

Reviewers

deadalnix
Fabien

Group Reviewers

Restricted Project

Commits

rSTAGING105a473fc6dd: Merge #11099: [RPC][mempool]: Add savemempool RPC
rABC105a473fc6dd: Merge #11099: [RPC][mempool]: Add savemempool RPC

Summary

1aa97ee08 Add savemempool RPC (Lawrence Nahum)
467cbbcbf Add return value to DumpMempool (Lawrence Nahum)

Pull request description:

Adds a simple parameterless rpc command to dump the mempool.

Rationale:

Sometimes there can be a crash for whatever reason (bug, power loss, etc) causing the mempool.dat file to not be saved.

This change allows to script/cron the rpc call to have more regular saves to the file as well as cli/ad-hoc.

This should solve issue https://github.com/bitcoin/bitcoin/issues/11086

Tree-SHA512: e856ae9777425a4521279c9b58e69285d8e374790bebefd3284cf91931eac0e456f86224f427a087a01bf70440bf6e439fa02c8a34940eb1046ae473e98b6aaa

Backport of Core PR 11099
https://github.com/bitcoin/bitcoin/pull/11099/files

Test Plan

make check
test_runner.py mempool_persist

Diff Detail

Repository

rABC Bitcoin ABC

Lint

Lint Not Applicable

Unit

Tests Not Applicable

Event Timeline

jasonbcox created this revision.May 6 2019, 23:09

Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 6 2019, 23:09

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5704: Diff 8432.May 6 2019, 23:24

jasonbcox added a child revision: D2952: Make functions in rpc/blockchain.cpp static..May 6 2019, 23:55

jasonbcox added a child revision: D2957: Merge #12172: Bugfix: RPC: savemempool: Don't save until LoadMempool() is finished.May 7 2019, 00:37

What do you think backporting PR12172 (D2957) and https://github.com/bitcoin/bitcoin/pull/12842 alongside this diff? This will avoid having open issues in the codebase.