Page MenuHomePhabricator

Merge #9539: [net] Avoid initialization to a value that is never read
ClosedPublic

Authored by jasonbcox on May 7 2019, 19:25.

Details

Summary

5844609 [net] Avoid initialization to a value that is never read (practicalswift)

Tree-SHA512: 068c3fba58034187f546688bc9b8b7317e0657e797850613fb6289a4efc28637e4d06a0fa5e57480538c6b8340ed6d6a6c6f9a96f130b698d5d60975490a03d8

Backport Core PR 9539
https://github.com/bitcoin/bitcoin/pull/9539/files

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Branch
pr9539
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5732
Build 9526: Bitcoin ABC Buildbot (legacy)
Build 9525: arc lint + arc unit

Event Timeline

markblundeberg added a subscriber: markblundeberg.

A note: Bizarrely, in the POSIX form it's not clear whether the string will be nul-terminated if it happens to be exactly buf-sized. https://chromium.googlesource.com/chromium/src/base/+/master/posix/safe_strerror.cc#78 )

This revision is now accepted and ready to land.May 7 2019, 21:11