Page MenuHomePhabricator
Differential D2985

Merge #9906: Disallow copy constructor CReserveKeys
ClosedPublic
Actions

Authored by markblundeberg on May 8 2019, 02:28.

Details

Reviewers
jasonbcox
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGfb64f680eef6: Merge #9906: Disallow copy constructor CReserveKeys
rABCfb64f680eef6: Merge #9906: Disallow copy constructor CReserveKeys
Summary

Backport PR9906 https://github.com/bitcoin/bitcoin/pull/9906/files
188f89c Disallow copy of CReserveKeys (Gregory Sanders)

Tree-SHA512: e55ce10bf7f2dc91de9797e60ab7767fb51f25255995d62ddf358c52b7aaa23c26fbfb522e1610ff950b86804ddbc38dc0d7708bfab2c4d33ad99a275d8c77db

Test Plan

compile

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5749
Build 9560: Bitcoin ABC Buildbot (legacy)
Build 9559: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 8 2019, 02:28
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 8 2019, 02:28
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 8 2019, 02:28

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

markblundeberg added a comment.May 8 2019, 02:31

first constructor to be removed in PR 15108 later on

Harbormaster completed remote builds in B5749: Diff 8493.May 8 2019, 02:43
teamcity added a comment.May 8 2019, 02:43

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.May 8 2019, 19:22
This revision is now accepted and ready to land.May 8 2019, 19:22
Closed by commit rABCfb64f680eef6: Merge #9906: Disallow copy constructor CReserveKeys (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 8 2019, 20:24
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGfb64f680eef6: Merge #9906: Disallow copy constructor CReserveKeys.Sep 18 2019, 23:23

Revision Contents
Changeset List

PathSize
src/
wallet/
4 lines

Diff 8493

View Options

src/wallet/wallet.h

Loading...