Page MenuHomePhabricator

Merge #9916: Fix msvc compiler error C4146 (minus operator applied to unsigned type)
ClosedPublic

Authored by markblundeberg on May 8 2019, 03:01.

Details

Summary

backport PR9916 https://github.com/bitcoin/bitcoin/pull/9916/files
8e0720b Fix msvc compiler error C4146 (unary minus operator applied to unsigned type) (kobake)
292112f Fix msvc compiler error C4146 (minus operator applied to unsigned type) (kobake)

Tree-SHA512: 25f408daf7bf9ffe4b8b4bd62f6f6d326219189a9faf8f8c0a135c5a0cb0511af765aa2b6087a091c8863c701289bda49a2379b00cd9b10854d316a5c3fc3f8e

Test Plan

make check

Diff Detail

Repository
rABC Bitcoin ABC
Lint
Automatic diff as part of commit; lint not applicable.
Unit
Automatic diff as part of commit; unit tests not applicable.

Event Timeline

markblundeberg created this revision.May 8 2019, 03:01
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 8 2019, 03:01
jasonbcox accepted this revision.May 8 2019, 18:32

Stupid, but I don't want to own this code right now...

This revision is now accepted and ready to land.May 8 2019, 18:32
jasonbcox requested changes to this revision.May 8 2019, 18:33
jasonbcox added inline comments.
src/bloom.cpp
268 ↗(On Diff #8496)

keep the uint64_t(...) style

This revision now requires changes to proceed.May 8 2019, 18:33
jasonbcox accepted this revision.May 8 2019, 21:28
This revision is now accepted and ready to land.May 8 2019, 21:28