Page MenuHomePhabricator
Differential D2994

Merge #9734: Add updating of chainTxData to release process
AbandonedPublic
Actions

Authored by markblundeberg on May 8 2019, 05:46.

Details

Reviewers
jasonbcox
Fabien
deadalnix
Group Reviewers
Restricted Project
Summary

backport PR9734 https://github.com/bitcoin/bitcoin/pull/9734/files
41b8821 Add updating of chainTxData to release process (Pieter Wuille)

Tree-SHA512: f7d6e72b19aa83fc4851a9316d6c6a236e0e914d637525cda42c0b15a94543b8072ce67b57d6b12141332a03b64b6c715dff4d61e6e58e0197b22305b35ad65d

(moved for new layout)

Test Plan

read

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5758
Build 9578: Bitcoin ABC Buildbot (legacy)
Build 9577: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 8 2019, 05:46
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 8 2019, 05:47
Herald added a reviewer: deadalnix. · View Herald Transcript
teamcity added a comment.May 8 2019, 05:47

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

teamcity added a comment.May 8 2019, 06:01

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

Harbormaster completed remote builds in B5758: Diff 8502.May 8 2019, 06:01
jasonbcox requested changes to this revision.May 8 2019, 18:13

I can't find the comment right now, but we had a short convo about not adding this at this time. The value of doing so isn't clear beyond estimating IBD time in the GUI. If that's true, we already know it to be quite inaccurate, so doing this just adds work to our release process.

This revision now requires changes to proceed.May 8 2019, 18:13
markblundeberg added a comment.May 8 2019, 18:15
In D2994#70355, @jasonbcox wrote:

I can't find the comment right now, but we had a short convo about not adding this at this time. The value of doing so isn't clear beyond estimating IBD time in the GUI. If that's true, we already know it to be quite inaccurate, so doing this just adds work to our release process.

Ah no problem then!

markblundeberg abandoned this revision.May 8 2019, 18:37

Revision Contents
Changeset List

PathSize
doc/
1 line

Diff 8502

View Options

doc/release-process.md

Loading...