Page MenuHomePhabricator
Differential D2998

Merge #9724: Qt/Intro: Add explanation of IBD process
ClosedPublic
Actions

Authored by markblundeberg on May 8 2019, 20:21.

Details

Reviewers
jasonbcox
Fabien
deadalnix
Group Reviewers
Restricted Project
Commits
rSTAGINGf4b53e0c1ae4: Merge #9724: Qt/Intro: Add explanation of IBD process
rABCf4b53e0c1ae4: Merge #9724: Qt/Intro: Add explanation of IBD process
Summary

backport PR9724 https://github.com/bitcoin/bitcoin/pull/9724/files
f6d18f5 Qt/Intro: Explain a bit more what will happen first time (Luke Dashjr)
50c5657 Qt/Intro: Storage shouldn't grow significantly with pruning enabled (Luke Dashjr)
9adb694 Qt/Intro: Move sizeWarningLabel text into C++ code (Luke Dashjr)

Test Plan

make check
qt/test/test_bitcoin-qt

  • Run bitcoin for first time with no .bitcoin directory, to see intro screen.
  • Run again with -prune=1000 to see that prune-related text.

Diff Detail

Repository
rABC Bitcoin ABC
Branch
patch
Lint
Lint Passed
Unit
No Test Coverage
Build Status
Buildable 5765
Build 9592: Bitcoin ABC Buildbot (legacy)
Build 9591: arc lint + arc unit

Event Timeline

markblundeberg created this revision.May 8 2019, 20:21
Herald added a reviewer: Restricted Project. · View Herald TranscriptMay 8 2019, 20:21
Herald added a reviewer: deadalnix. · View Herald Transcript
markblundeberg edited the test plan for this revision. (Show Details)May 8 2019, 20:23
teamcity added a comment.May 8 2019, 20:23

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing started.

Harbormaster completed remote builds in B5765: Diff 8526.May 8 2019, 20:37
teamcity added a comment.May 8 2019, 20:37

Build Bitcoin-ABC / Diffs / Bitcoin-ABC Diff Testing passed.

jasonbcox accepted this revision.May 8 2019, 21:33
This revision is now accepted and ready to land.May 8 2019, 21:33
Closed by commit rABCf4b53e0c1ae4: Merge #9724: Qt/Intro: Add explanation of IBD process (authored by Wladimir J. van der Laan <laanwj@gmail.com>, committed by Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com>). · Explain WhyMay 8 2019, 23:20
This revision was automatically updated to reflect the committed changes.
Mark Lundeberg <36528214+markblundeberg@users.noreply.github.com> added a commit: rSTAGINGf4b53e0c1ae4: Merge #9724: Qt/Intro: Add explanation of IBD process.Sep 18 2019, 23:24

Revision Contents
Changeset List

PathSize
src/
qt/
forms/
35 lines
22 lines

Diff 8526

View Options

src/qt/forms/intro.ui

Loading...
View Options

src/qt/intro.cpp

Loading...